From: Sebastian Keller <skeller@gnome.org>
Date: Wed, 1 Mar 2023 20:43:15 +0000 (+0100)
Subject: overview: Don't claim to be SHOWN when HIDDEN during startup animation
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~393^2^2~47
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=bb42973730a1a96881cb63bf7c1e9fdc68fb9fba;p=gnome-shell.git

overview: Don't claim to be SHOWN when HIDDEN during startup animation

When the overview gets hidden during the startup animation, the callback
would still change the state to SHOWN, despite the overview not being
shown.

This can happen for example if a `monitors-changed` signal triggers a
relayout during startup.

See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2514#note_1683525
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2667>
---

diff --git a/js/ui/overview.js b/js/ui/overview.js
index 4dd59d4ae..22bd4c4f5 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -683,6 +683,12 @@ var Overview = class extends Signals.EventEmitter {
         this._changeShownState(OverviewShownState.SHOWING);
 
         this._overview.runStartupAnimation(() => {
+            // Overview got hidden during startup animation
+            if (this._shownState !== OverviewShownState.SHOWING) {
+                callback();
+                return;
+            }
+
             if (!this._syncGrab()) {
                 callback();
                 return;